From cdc8e463b7e393458921d2d3788b0dd99feabc6d Mon Sep 17 00:00:00 2001
From: orignal <i2porignal@yandex.ru>
Date: Fri, 22 Oct 2021 19:18:45 -0400
Subject: [PATCH] use memory pool for outgoing tunnel gateway messages

---
 libi2pd/I2NPProtocol.cpp |  9 +--------
 libi2pd/Tunnel.cpp       | 22 ++++++++++++++++------
 libi2pd/Tunnel.h         |  6 ++++--
 3 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/libi2pd/I2NPProtocol.cpp b/libi2pd/I2NPProtocol.cpp
index fa4fa7a6..bdd65d30 100644
--- a/libi2pd/I2NPProtocol.cpp
+++ b/libi2pd/I2NPProtocol.cpp
@@ -38,14 +38,7 @@ namespace i2p
 
 	std::shared_ptr<I2NPMessage> NewI2NPTunnelMessage (bool endpoint)
 	{
-		if (endpoint)
-			return i2p::tunnel::tunnels.NewI2NPTunnelMessage ();
-		else
-		{
-			auto msg = new I2NPMessageBuffer<i2p::tunnel::TUNNEL_DATA_MSG_SIZE + I2NP_HEADER_SIZE + 34>(); // reserved for alignment and NTCP 16 + 6 + 12
-			msg->Align (12);
-			return std::shared_ptr<I2NPMessage>(msg);	
-		}
+		return i2p::tunnel::tunnels.NewI2NPTunnelMessage (endpoint);
 	}
 
 	std::shared_ptr<I2NPMessage> NewI2NPMessage (size_t len)
diff --git a/libi2pd/Tunnel.cpp b/libi2pd/Tunnel.cpp
index 3de91940..a315ff49 100644
--- a/libi2pd/Tunnel.cpp
+++ b/libi2pd/Tunnel.cpp
@@ -566,6 +566,7 @@ namespace tunnel
 					}	
 					if (ts - lastMemoryPoolTs >= 120) // manage memory pool every 2 minutes
 					{
+						m_I2NPTunnelEndpointMessagesMemoryPool.CleanUpMt ();
 						m_I2NPTunnelMessagesMemoryPool.CleanUpMt ();
 						lastMemoryPoolTs = ts;
 					}	
@@ -940,13 +941,22 @@ namespace tunnel
 		return outboundTunnel;
 	}
 
-	std::shared_ptr<I2NPMessage> Tunnels::NewI2NPTunnelMessage ()
+	std::shared_ptr<I2NPMessage> Tunnels::NewI2NPTunnelMessage (bool endpoint)
 	{
-		// should fit two tunnel message + tunnel gateway header, enough for one garlic encrypted streaming packet
-		auto msg = m_I2NPTunnelMessagesMemoryPool.AcquireSharedMt (); 
-		msg->Align (6);
-		msg->offset += TUNNEL_GATEWAY_HEADER_SIZE; // reserve room for TunnelGateway header
-		return msg;
+		if (endpoint)
+		{	
+			// should fit two tunnel message + tunnel gateway header, enough for one garlic encrypted streaming packet
+			auto msg = m_I2NPTunnelEndpointMessagesMemoryPool.AcquireSharedMt (); 
+			msg->Align (6);
+			msg->offset += TUNNEL_GATEWAY_HEADER_SIZE; // reserve room for TunnelGateway header
+			return msg;
+		}	
+		else
+		{
+			auto msg = m_I2NPTunnelMessagesMemoryPool.AcquireSharedMt (); 
+			msg->Align (12);
+			return msg;
+		}	
 	}	
 		
 	int Tunnels::GetTransitTunnelsExpirationTimeout ()
diff --git a/libi2pd/Tunnel.h b/libi2pd/Tunnel.h
index 30d9d565..56166e0b 100644
--- a/libi2pd/Tunnel.h
+++ b/libi2pd/Tunnel.h
@@ -41,6 +41,7 @@ namespace tunnel
 	const int MAX_NUM_RECORDS = 8;
 	const int HIGH_LATENCY_PER_HOP = 250; // in milliseconds
 	
+	const size_t I2NP_TUNNEL_MESSAGE_SIZE = TUNNEL_DATA_MSG_SIZE + I2NP_HEADER_SIZE + 34; // reserved for alignment and NTCP 16 + 6 + 12
 	const size_t I2NP_TUNNEL_ENPOINT_MESSAGE_SIZE = 2*TUNNEL_DATA_MSG_SIZE + I2NP_HEADER_SIZE + TUNNEL_GATEWAY_HEADER_SIZE + 28; // reserved for alignment and NTCP 16 + 6 + 6 
 	
 	enum TunnelState
@@ -222,7 +223,7 @@ namespace tunnel
 			void DeleteTunnelPool (std::shared_ptr<TunnelPool> pool);
 			void StopTunnelPool (std::shared_ptr<TunnelPool> pool);
 
-			std::shared_ptr<I2NPMessage> NewI2NPTunnelMessage ();
+			std::shared_ptr<I2NPMessage> NewI2NPTunnelMessage (bool endpoint);
 			
 		private:
 
@@ -262,7 +263,8 @@ namespace tunnel
 			std::list<std::shared_ptr<TunnelPool>> m_Pools;
 			std::shared_ptr<TunnelPool> m_ExploratoryPool;
 			i2p::util::Queue<std::shared_ptr<I2NPMessage> > m_Queue;
-			i2p::util::MemoryPoolMt<I2NPMessageBuffer<I2NP_TUNNEL_ENPOINT_MESSAGE_SIZE> > m_I2NPTunnelMessagesMemoryPool;
+			i2p::util::MemoryPoolMt<I2NPMessageBuffer<I2NP_TUNNEL_ENPOINT_MESSAGE_SIZE> > m_I2NPTunnelEndpointMessagesMemoryPool;
+			i2p::util::MemoryPoolMt<I2NPMessageBuffer<I2NP_TUNNEL_MESSAGE_SIZE> > m_I2NPTunnelMessagesMemoryPool;
 			
 			// some stats
 			int m_NumSuccesiveTunnelCreations, m_NumFailedTunnelCreations;