From 3d42a4be4bc75f4f6da0ce41a19fb24cc83cf00b Mon Sep 17 00:00:00 2001 From: "chess.griffin" Date: Fri, 30 Jan 2009 02:49:32 +0000 Subject: [PATCH] update for-next-release --- for-next-release | 50 ++++++++++++++++++------------------------------ 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/for-next-release b/for-next-release index 23638ec..f02d45a 100644 --- a/for-next-release +++ b/for-next-release @@ -1,49 +1,34 @@ SHORT TERM TODO FOR NEXT RELEASE -Bring in Mauro's new update list code. DONE. +1. Look at slakmagik's 'useless uses of cat' patch. -Fix issue where loading/saving queue re-sorts them (have the fix). It should -not re-sort -- when loading, it should overwrite or append (see next item); -when saving, it should use copy the temp queue to the saved queue, nothing -more. DONE. +2. Look at slakmagik's 'return code reassignment plus' patch -Fix issue where loading backup or user-saved queue overwrites current tmp -queue. Suppose user adds a lot to the queue before going to the queue menu? -Instead, maybe automatically append or ask if user wants to overwrite or -append (have the fix). DONE. +3. Look at slakmagik's misc patch vs. r420 -Whitespace cleanups - 70 or 78 columns? Leaning towards 78. DONE - 78 :) +4. Fix security issue raised by Phillip Warner: check to make sure pkgs in +$OUTPUT are root:root permissions. Also, use idea by slakmagik of 'hiding' +certain menu elements if user is not root. I think we need to hide the +'Build" and 'Install' choices in the info_item menu, and hide the 'Process +Queue' in the Queue menu. -Add code re: unselecting apps in 'view_queue' changes to OFF, instead of -removing them (have this working but not committed yet). See sbopkg ML. -DONE. +5. Work on add_item_to_queue loop so messages are only displayed when a +package is in the queue and the user has to decide whether to replace or skip. +Do not give a message after each item is added. Maybe that message needs to +only be used in the info_item menu after a package is added or in the search +results page. -Once the unselecting code is added, need to revisit how to delete individual -items from queue. Maybe have the current "Clear Queue" menu item take the -user to another checklist of the queue, but in this one unselecting items -/will/ remove them and also offer a button to 'clear' the entire queue at -once. See sbopkg ML. DONE. +6. See other issues in Phillip's email and also issues raised on sbopkg ML. -Fix issue where download does not complete at all -- maybe mirror times out -- -and currently sbopkg still tests for md5sum, which is dumb. It should know if -there is nothing in the temporarily-created download directory and tell user -that download failed, and not offer to delete the source since there is no -source. Along these lines, one user mentioned that when this happened, the -item that failed the download was skipped when the user aborted the queue and -reran it. I could not reproduce this, but need to check it out. SHOULD BE -DONE. -Do not ask user if they want to keep or clear queue when doing a single build -(i.e. where BUILDPKGS != 1). DONE. - -Would it be helpful to have a way to run a queue through the update function? +7. Would it be helpful to have a way to run a queue through the update function? Suppose you have a saved queue with several deps and a final pkg, and some of those deps have been updated in the repo but the saved queue has older versions. If the queue is processed, it will automatically pick up the newer versions, but that is only for building and those changes are not 'saved' to the queue. Maybe it would be helpful to be able to update a queue (but not run it). -Maybe standardize all the "Done" type dialogs. Perhaps create a simple +8. Maybe standardize all the "Done" type dialogs. Perhaps create a simple function that displays "Done" (similar to the empty_queue function) and then call the function whenever a "Done" message is needed. We could even set it so you can pass an argument, which would be specific text depending on what @@ -57,3 +42,6 @@ dialog --title "Done" --msgbox "stuff $MSG" ... done_msg "The cache has been cleared" +ok + +UPDATE: I don't think this saves us much.