mirrors/sbopkg
2
0
Fork 0
mirror of https://github.com/sbopkg/sbopkg synced 2024-11-12 21:10:21 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug in updates_compare_versions()

Browse Source 
The loop index $i was not protected with curly braces in eval statement
of variable LEFT. When i=10 that statement was not evaluated as $10, but
as $1 concatenated with the digit 0.

Corrected description of outputs of updates_compare_versions().
This commit is contained in:
arcctgx 2018-04-25 20:16:03 +02:00
parent b86719b883
commit f3a408c4b1
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/usr/sbin/sbopkg
View File

@ -971,14 +971,14 @@ updates_compare_versions() {
# 1.2.50 build 4, the argument list is # 1.2.50 build 4, the argument list is
# 1 2 3 7 1 2 50 4 # 1 2 3 7 1 2 50 4
# Prints -1 if the "left" package is newer (not an update), 0 if # Prints -1 if the "left" package is newer (not an update), 0 if
# the version is unchanged, 1 if the "left" package is newer. # the version is unchanged, 1 if the "left" package is older.
local COUNT=$(($# / 2)) local COUNT=$(($# / 2))
local i RESULT=0 local i RESULT=0
local LEFT RIGHT local LEFT RIGHT
for ((i=1; i<=$COUNT; i++)); do for ((i=1; i<=$COUNT; i++)); do
eval LEFT=\$$i eval LEFT=\${$i}
eval RIGHT=\${$(($i + $COUNT))} eval RIGHT=\${$(($i + $COUNT))}
if [[ 10#$LEFT -lt 10#$RIGHT ]]; then if [[ 10#$LEFT -lt 10#$RIGHT ]]; then
RESULT=1 RESULT=1