Prior to r361, there were two places where the slack-desc
was parsed: in the "package browser" and in the "search
results". r361 tossed most of the "package browser" code,
including that part.
It happens that the two implementation were different,
and of course the removed one was the better of the two.
This patch applies a further improved implementation to
the current code.
Thanks to "jsunx1" for providing the original
implementation and for pointing out the regression.
Thanks to Chess Griffin for preparing and sending me
a patch restoring the old behavior.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Clean up the Original/Local selection code a
little, removing an useless loop and making
"Local" the default choice.
Thanks to "jsunx1" for raising the issue and
providing a partial implementation.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
I don't know what was the problem with this, but
I haven't found indication of a rename in the
slackbuilds.org mailing list or in the repository
itself.
For this reason, remove it from the sbopkg-renames
file.
Note that I still don't know the reason for the
old quirk, removed by r333.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Rework the main menu to reduce complexity and code
replication.
Thanks to "jsunx1" for suggesting this and for providing
a similar implementation.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
The implementation of r365 has some major problem,
deleting the permanent log being the most user-visible.
Undo that crud and do the checks in a proper way.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Make sure that the files and folders specified in the
configuration file can be created/accessed, and create
the directories if required.
This also fixes some bugs, such as the log not being
created if the LOGFILE specifies a nonexistent directory.
Thank to Alex for pointing this problem out.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Remove the old code for replacing hex codes in URLs
(like %2B for '+') and add a generic code replacing
any %xy sequence with the proper character.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
The "check for updates" confirmation dialog should
abort checking when the user presses ESC.
Thanks to Alex for reporting the issue.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Use the "-x" option with grep, instead of using "^$"
in the regular expression.
Thanks to Slakmagik for pointing this out.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
A lot of the package browser code replicates the search
functionality.
This patch extends the search infrastructure a bit and
uses that for browsing, too.
Many thanks to Chess for point out the major problems
affecting earlier releases of this patch.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Signed-off-by: Chess Griffin
If $PIDFILE exists, verify whether it refers to a running
process. This way the amount of false positives is greatly
reduced, which is a good thing during development when
a crash can terminate sbopkg leaving the $PIDFILE in place.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Remove a stale "exit" introduced by r354, causing sbopkg
to exit whenever a new directory is created.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Fix the following bugs:
- "dialog" segfaults when asked to display an empty
menu, so avoid that
- the "empty queue" test is done checking the existence
of $TMPQUEUE, not its content. For this reason,
delete $TMPQUEUE if it only contains whitespace.
Also, declare some variables as local.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Fix view_queue selection with packages whose name is the initial
part of another package name (e.g. "libbonobo" and "libbonoboui").
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
