mauro.giachero
0fcf52265b
Validation: revert r365 and do it properly.
...
The implementation of r365 has some major problem,
deleting the permanent log being the most user-visible.
Undo that crud and do the checks in a proper way.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-23 16:11:57 +00:00
chess.griffin
a4ff19fadc
revise PAGER fix for show_readme; thanks to slakmagik for the suggestion; remove the 'warning' before running an update check -- adds an unnecessary step and the point about the update debugging really is not relevant anymore.
2009-01-23 00:07:37 +00:00
chess.griffin
f856f309b8
remove minor cruft; mark old code as FIXME for future deletion
2009-01-22 22:30:49 +00:00
chess.griffin
7e2c041fd9
commit modified patch from slakmagik re: converting case of KEEPLOG and testing its value before showing the permanent log in dialog; fix some issues in the 'delete items from queue' where empty/blank lines would end up in the queue, messing things up; since PIDFILE is now set locally, use full name in cleanup function.
2009-01-22 21:34:22 +00:00
mauro.giachero
75c087660c
Validate the files/folders specified in sbopkg.conf
...
Make sure that the files and folders specified in the
configuration file can be created/accessed, and create
the directories if required.
This also fixes some bugs, such as the log not being
created if the LOGFILE specifies a nonexistent directory.
Thank to Alex for pointing this problem out.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 16:45:39 +00:00
mauro.giachero
459c36864a
Downloads: implement proper URL hex substitution.
...
Remove the old code for replacing hex codes in URLs
(like %2B for '+') and add a generic code replacing
any %xy sequence with the proper character.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 16:45:29 +00:00
mauro.giachero
102d89c316
Updates: fix confirmation dialog ESC behavior
...
The "check for updates" confirmation dialog should
abort checking when the user presses ESC.
Thanks to Alex for reporting the issue.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 16:45:19 +00:00
mauro.giachero
166fe433e6
Use line matching with grep.
...
Use the "-x" option with grep, instead of using "^$"
in the regular expression.
Thanks to Slakmagik for pointing this out.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 16:45:10 +00:00
mauro.giachero
6bca567933
Package browser: use the search infrastructure
...
A lot of the package browser code replicates the search
functionality.
This patch extends the search infrastructure a bit and
uses that for browsing, too.
Many thanks to Chess for point out the major problems
affecting earlier releases of this patch.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
Signed-off-by: Chess Griffin
2009-01-22 16:45:00 +00:00
mauro.giachero
cd1f6aa495
pid_check: verify older PID's existence.
...
If $PIDFILE exists, verify whether it refers to a running
process. This way the amount of false positives is greatly
reduced, which is a good thing during development when
a crash can terminate sbopkg leaving the $PIDFILE in place.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 11:28:16 +00:00
mauro.giachero
52cbcbcbde
Fix directory creation.
...
Remove a stale "exit" introduced by r354, causing sbopkg
to exit whenever a new directory is created.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-22 11:28:06 +00:00
chess.griffin
d02f7d8ab7
update for-next-release
2009-01-22 03:51:43 +00:00
chess.griffin
3e5420981c
update for-next-release
2009-01-22 03:42:55 +00:00
chess.griffin
31a2952cbf
update for-next-release
2009-01-22 03:38:48 +00:00
chess.griffin
78fadc30cd
update Changelog-current.txt
2009-01-22 03:34:52 +00:00
chess.griffin
acf87ceed2
commit patch from slakmagik that improves the handling of the creation of sbopkg-related directories; fix two issues found in recent patches - line split in show_readme broke PAGER; also, incorrect dialog labeling in remove_sources caused that function to fail.
2009-01-22 03:21:43 +00:00
chess.griffin
06c03ecfdc
commit patch from slakmagik that improves the checking of root privileges and how error messages related to not having root privileges are handled; thanks to slakmagik for the patch.
2009-01-22 03:03:51 +00:00
chess.griffin
0ab309ea81
commit patch from slakmagik that tweaks the precheck log a bit
2009-01-22 01:32:00 +00:00
chess.griffin
8b4c2e1f19
commit patch from slakmagik that brings user straight back to search box if search fails
2009-01-22 01:29:47 +00:00
chess.griffin
5cb04eb9a8
fix issue where downloaded sources with a space would fail md5sum check (GNOME-Colors, for example); also fix issue with erroneous check for empty_queue when using -b or -i from cli.
2009-01-22 01:26:46 +00:00
chess.griffin
8d4fba2225
a few minor tweaks to some comments; clarify that deleting all items from queue cannot be undone; fix issue in save_user_queue where the queue was sorted, it now just copies the TMPQUEUE to the USERQUEUE.
2009-01-21 13:45:24 +00:00
mauro.giachero
61268e5344
Fixes to delete_build_queue.
...
Fix the following bugs:
- "dialog" segfaults when asked to display an empty
menu, so avoid that
- the "empty queue" test is done checking the existence
of $TMPQUEUE, not its content. For this reason,
delete $TMPQUEUE if it only contains whitespace.
Also, declare some variables as local.
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-21 11:45:43 +00:00
mauro.giachero
f2c618b8e9
Fix view_queue selection with overlapping names.
...
Fix view_queue selection with packages whose name is the initial
part of another package name (e.g. "libbonobo" and "libbonoboui").
Signed-off-by: Mauro Giachero <mauro.giachero@gmail.com>
2009-01-21 08:33:45 +00:00
chess.griffin
97ae2a37a6
provide error msg if trying to run updates when using LOCALREPO/local directory
2009-01-21 04:59:28 +00:00
chess.griffin
34689ae6f5
tweak sbopkg.conf(5) man page
2009-01-21 03:20:40 +00:00
chess.griffin
1987c6fd26
edit both man pages about /local directory; other minor nits
2009-01-21 03:18:39 +00:00
chess.griffin
91ca26e6c3
modify sbopkg.conf for LOGFILE; other cleanups in same man page
2009-01-21 03:09:26 +00:00
chess.griffin
54fda65ea5
add support for /home/sbo/local; check if SLACKVER is 'local' before trying to do rsync.
2009-01-21 03:01:37 +00:00
chess.griffin
7279ec8fd2
update ChangeLog-current.txt
2009-01-21 01:35:04 +00:00
chess.griffin
ee51ae0328
add in new sbopkg-renames file which is needed for Mauro's update code.
2009-01-21 01:19:39 +00:00
chess.griffin
3707f1a3cf
use new add_item_to_queue function when backup queue is loaded or when user's saved queue is loaded.
2009-01-21 01:05:19 +00:00
chess.griffin
59ef49e159
merge in two patches from slakmagik that allow the user to maintain (and retain between rsyncs) an optional /local/ directory in the local SBo repo tree where the user could have other SlackBuilds created and maintained locally in the SBo style; also, second patch introduces LOGFILE sbopkg.conf variable, which allows the user to set the name and location of the permanent build log; thanks to slakmagik for these two very nice additions.
2009-01-21 00:55:00 +00:00
chess.griffin
da2fa378f7
only check empty_queue in process_queue when BUILDPKGS=1
2009-01-20 22:49:56 +00:00
chess.griffin
db57b92f08
add initial implementation of new delete_build_queue instead of clear_build_queue; this function allows user to remove individual items from queue or delete the whole queue; there are probably other/better ways to do this but this is a first crack at it.
2009-01-20 22:13:13 +00:00
chess.griffin
28950518c6
add new Changelog-current.txt to keep track of changes made for next release
2009-01-20 04:59:11 +00:00
chess.griffin
1a4afd58da
modify add_item_to_queue so the three arguments passed to it are APP, VERSIONBUILD, and ONOFF, which make it possible to send the results of the sbopkg-update-queue to this new function for processing
2009-01-20 04:58:06 +00:00
chess.griffin
0d89a29fa0
merge in Mauro's new update code.
2009-01-20 04:38:16 +00:00
chess.griffin
17a05947c2
minor tweaks to add_item_to_queue.
2009-01-20 04:09:42 +00:00
chess.griffin
736b669f67
add two calls to the new add_item_to_queue function, one in the info_item menu (where users add individual items) and in the search results dialog; also add in the code to add_item_to_queue that replaces APP if the user so chooses.
2009-01-20 04:03:06 +00:00
chess.griffin
a2654dd298
fix a few things in add_item_to_queue
2009-01-20 03:39:51 +00:00
chess.griffin
2578c33894
minor whitespace fix; add a new 'add_item_to_queue' that will be a function called from several places -- it takes APP and VERSIONBUILD as arguments, and then tests to see if APP is already in the queue; if not, add it; if so, then ask user if they want to replace or skip. See the comment to this function for more info. This function is not finished and is not called anywhere yet.
2009-01-20 03:35:45 +00:00
chess.griffin
4c37d528ee
create an 'empty_queue' function to test if TMPQUEUE is empty since that is done in several places, and then in those other places, just test the return of empty_queue; bring in initial code in the view_queue function where deselecting an item in the queue changes it status from ON to OFF and does not remove it from queue; still need to implement a way to remove items from queue -- maybe turn the 'clear queue' menu item into another checklist where folks can remove individual items or clear the queue.
2009-01-20 03:20:12 +00:00
chess.griffin
da9511b197
commit a large whitespace patch, which does several things, including adding the 'crunch' functions to eliminate extra spaces, reformats the entire script around 78 columns, and improves the formatting of functions and comments; thanks to slakmagik for the patch.
2009-01-20 02:16:19 +00:00
chess.griffin
ca4d249836
add for-next-release file to document short term TODOs
2009-01-19 04:15:03 +00:00
chess.griffin
793ad8511c
apply alternate usage patch from slakmagik -- this uses EOF to create the -h help information rather than a bunch of echo lines.
2009-01-18 20:01:09 +00:00
chess.griffin
be7b5f75a1
tag and release 0.25.0
2009-01-17 02:35:02 +00:00
chess.griffin
c1d9f5a0bb
revert a minor change to the size of a dialog.
2009-01-17 02:13:46 +00:00
chess.griffin
7e6349b150
add menu item and function to clear build queue.
2009-01-17 02:04:09 +00:00
chess.griffin
9ed8e475c9
tweak how the temporary backup queue is managed; now it is removed automatically whether the user loads it or not.
2009-01-17 00:33:18 +00:00
chess.griffin
f777578f0f
forgot to add one change to the check for path code
2009-01-16 21:23:07 +00:00
