From adcfc212c0561a972ff30c9d860d32874eb88d27 Mon Sep 17 00:00:00 2001 From: default Date: Wed, 20 Dec 2023 09:15:25 +0100 Subject: [PATCH] Check some fwrite() return values in xs_fcgi_response(). --- xs_fcgi.h | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/xs_fcgi.h b/xs_fcgi.h index 50115b1..a7b766f 100644 --- a/xs_fcgi.h +++ b/xs_fcgi.h @@ -336,21 +336,23 @@ void xs_fcgi_response(FILE *f, int status, xs_dict *headers, xs_str *body, int b int offset = 0; while (offset < size) { - int sz = size - offset; + size_t sz = size - offset; if (sz > 0xffff) sz = 0xffff; hdr.content_len = htons(sz); - fwrite(&hdr, sizeof(hdr), 1, f); - fwrite(out + offset, 1, sz, f); + /* write or fail */ + if (!fwrite(&hdr, sizeof(hdr), 1, f) || fwrite(out + offset, 1, sz, f) != sz) + return; offset += sz; } /* final STDOUT packet with 0 size */ hdr.content_len = 0; - fwrite(&hdr, sizeof(hdr), 1, f); + if (!fwrite(&hdr, sizeof(hdr), 1, f)) + return; /* complete the connection */ ereq.app_status = 0; @@ -359,8 +361,8 @@ void xs_fcgi_response(FILE *f, int status, xs_dict *headers, xs_str *body, int b hdr.type = FCGI_END_REQUEST; hdr.content_len = htons(sizeof(ereq)); - fwrite(&hdr, sizeof(hdr), 1, f); - fwrite(&ereq, sizeof(ereq), 1, f); + if (fwrite(&hdr, sizeof(hdr), 1, f)) + fwrite(&ereq, sizeof(ereq), 1, f); }