Remove unnecessary selects

src/yggdrasil/admin.go

@@ -57,17 +57,15 @@ func (a *admin) init(c *Core) {
 	a.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-a.reconfigure
-			case e := <-a.reconfigure:
+			a.core.configMutex.RLock()
-				a.core.configMutex.RLock()
+			if a.core.config.AdminListen != a.core.configOld.AdminListen {
-				if a.core.config.AdminListen != a.core.configOld.AdminListen {
+				a.listenaddr = a.core.config.AdminListen
-					a.listenaddr = a.core.config.AdminListen
+				a.close()
-					a.close()
+				a.start()
-					a.start()
-				}
-				a.core.configMutex.RUnlock()
-				e <- nil
 			}
+			a.core.configMutex.RUnlock()
+			e <- nil
 		}
 	}()
 	a.core.configMutex.RLock()

src/yggdrasil/dht.go

@@ -82,10 +82,8 @@ func (t *dht) init(c *Core) {
 	t.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-t.reconfigure
-			case e := <-t.reconfigure:
+			e <- nil
-				e <- nil
-			}
 		}
 	}()
 	t.nodeID = *t.core.GetNodeID()

src/yggdrasil/multicast.go

@@ -25,13 +25,11 @@ func (m *multicast) init(core *Core) {
 	m.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-m.reconfigure
-			case e := <-m.reconfigure:
+			m.myAddrMutex.Lock()
-				m.myAddrMutex.Lock()
+			m.myAddr = m.core.tcp.getAddr()
-				m.myAddr = m.core.tcp.getAddr()
+			m.myAddrMutex.Unlock()
-				m.myAddrMutex.Unlock()
+			e <- nil
-				e <- nil
-			}
 		}
 	}()
 	m.groupAddr = "[ff02::114]:9001"

src/yggdrasil/peer.go

@@ -35,10 +35,8 @@ func (ps *peers) init(c *Core) {
 	ps.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-ps.reconfigure
-			case e := <-ps.reconfigure:
+			e <- nil
-				e <- nil
-			}
 		}
 	}()
 	ps.allowedEncryptionPublicKeys = make(map[crypto.BoxPubKey]struct{})

src/yggdrasil/search.go

@@ -53,10 +53,8 @@ func (s *searches) init(core *Core) {
 	s.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-s.reconfigure
-			case e := <-s.reconfigure:
+			e <- nil
-				e <- nil
-			}
 		}
 	}()
 	s.searches = make(map[crypto.NodeID]*searchInfo)

src/yggdrasil/session.go

@@ -131,21 +131,19 @@ func (ss *sessions) init(core *Core) {
 	ss.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-ss.reconfigure
-			case e := <-ss.reconfigure:
+			responses := make(map[crypto.Handle]chan error)
-				responses := make(map[crypto.Handle]chan error)
+			for index, session := range ss.sinfos {
-				for index, session := range ss.sinfos {
+				responses[index] = make(chan error)
-					responses[index] = make(chan error)
+				session.reconfigure <- responses[index]
-					session.reconfigure <- responses[index]
-				}
-				for _, response := range responses {
-					if err := <-response; err != nil {
-						e <- err
-						continue
-					}
-				}
-				e <- nil
 			}
+			for _, response := range responses {
+				if err := <-response; err != nil {
+					e <- err
+					continue
+				}
+			}
+			e <- nil
 		}
 	}()
 	ss.permShared = make(map[crypto.BoxPubKey]*crypto.BoxSharedKey)

src/yggdrasil/tcp.go

@@ -90,18 +90,16 @@ func (iface *tcpInterface) init(core *Core) (err error) {
 	iface.reconfigure = make(chan chan error, 1)
 	go func() {
 		for {
-			select {
+			e := <-iface.reconfigure
-			case e := <-iface.reconfigure:
+			iface.core.configMutex.RLock()
-				iface.core.configMutex.RLock()
+			updated := iface.core.config.Listen != iface.core.configOld.Listen
-				updated := iface.core.config.Listen != iface.core.configOld.Listen
+			iface.core.configMutex.RUnlock()
-				iface.core.configMutex.RUnlock()
+			if updated {
-				if updated {
+				iface.serv_stop <- true
-					iface.serv_stop <- true
+				iface.serv.Close()
-					iface.serv.Close()
+				e <- iface.listen()
-					e <- iface.listen()
+			} else {
-				} else {
+				e <- nil
-					e <- nil
-				}
 			}
 		}
 	}()

src/yggdrasil/tun.go

@@ -46,19 +46,17 @@ func (tun *tunAdapter) init(core *Core, send chan<- []byte, recv <-chan []byte)
 	tun.icmpv6.init(tun)
 	go func() {
 		for {
-			select {
+			e := <-tun.reconfigure
-			case e := <-tun.reconfigure:
+			tun.core.configMutex.RLock()
-				tun.core.configMutex.RLock()
+			updated := tun.core.config.IfName != tun.core.configOld.IfName ||
-				updated := tun.core.config.IfName != tun.core.configOld.IfName ||
+				tun.core.config.IfTAPMode != tun.core.configOld.IfTAPMode ||
-					tun.core.config.IfTAPMode != tun.core.configOld.IfTAPMode ||
+				tun.core.config.IfMTU != tun.core.configOld.IfMTU
-					tun.core.config.IfMTU != tun.core.configOld.IfMTU
+			tun.core.configMutex.RUnlock()
-				tun.core.configMutex.RUnlock()
+			if updated {
-				if updated {
+				tun.core.log.Println("Reconfiguring TUN/TAP is not supported yet")
-					tun.core.log.Println("Reconfiguring TUN/TAP is not supported yet")
+				e <- nil
-					e <- nil
+			} else {
-				} else {
+				e <- nil
-					e <- nil
-				}
 			}
 		}
 	}()