From 6f0bbbfb987c00e79a9eea460b0436c76928983f Mon Sep 17 00:00:00 2001
From: Arceliar <Arceliar@users.noreply.github.com>
Date: Fri, 15 Feb 2019 19:35:10 -0600
Subject: [PATCH] Debug some issues with the state machine that tracks idle
 connections in link.go

---
 src/yggdrasil/link.go   | 26 ++++++++++++++++++--------
 src/yggdrasil/switch.go |  1 +
 2 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/src/yggdrasil/link.go b/src/yggdrasil/link.go
index be98dd92..ad4b1fac 100644
--- a/src/yggdrasil/link.go
+++ b/src/yggdrasil/link.go
@@ -216,6 +216,8 @@ func (intf *linkInterface) handler() error {
 				case signalReady <- struct{}{}:
 				default:
 				}
+				intf.link.core.log.Debugf("Sending packet to %s: %s, source %s",
+					strings.ToUpper(intf.info.linkType), themString, intf.info.local)
 			}
 		}
 	}()
@@ -235,18 +237,21 @@ func (intf *linkInterface) handler() error {
 		recvTimer := time.NewTimer(recvTime)
 		defer util.TimerStop(recvTimer)
 		for {
+			intf.link.core.log.Debugf("State of %s: %s, source %s :: isAlive %t isReady %t sendTimerRunning %t recvTimerRunning %t",
+				strings.ToUpper(intf.info.linkType), themString, intf.info.local,
+				isAlive, isReady, sendTimerRunning, recvTimerRunning)
 			select {
 			case gotMsg, ok := <-signalAlive:
 				if !ok {
 					return
 				}
-				if !isAlive {
-					isAlive = true
-					if !isReady {
-						// (Re-)enable in the switch
-						isReady = true
-						intf.link.core.switchTable.idleIn <- intf.peer.port
-					}
+				util.TimerStop(recvTimer)
+				recvTimerRunning = false
+				isAlive = true
+				if !isReady {
+					// (Re-)enable in the switch
+					intf.link.core.switchTable.idleIn <- intf.peer.port
+					isReady = true
 				}
 				if gotMsg && !sendTimerRunning {
 					// We got a message
@@ -255,6 +260,10 @@ func (intf *linkInterface) handler() error {
 					sendTimer.Reset(sendTime)
 					sendTimerRunning = true
 				}
+				if !gotMsg {
+					intf.link.core.log.Debugf("Received ack from %s: %s, source %s",
+						strings.ToUpper(intf.info.linkType), themString, intf.info.local)
+				}
 			case sentMsg, ok := <-signalSent:
 				// Stop any running ack timer
 				if !ok {
@@ -273,12 +282,13 @@ func (intf *linkInterface) handler() error {
 				if !ok {
 					return
 				}
-				if !isAlive || !isReady {
+				if !isAlive {
 					// Disable in the switch
 					isReady = false
 				} else {
 					// Keep enabled in the switch
 					intf.link.core.switchTable.idleIn <- intf.peer.port
+					isReady = true
 				}
 			case <-sendTimer.C:
 				// We haven't sent anything, so signal a send of a 0 packet to let them know we're alive
diff --git a/src/yggdrasil/switch.go b/src/yggdrasil/switch.go
index 9d1f870a..a2877ebe 100644
--- a/src/yggdrasil/switch.go
+++ b/src/yggdrasil/switch.go
@@ -780,6 +780,7 @@ func (t *switchTable) doWorker() {
 	t.queues.bufs = make(map[string]switch_buffer) // Packets per PacketStreamID (string)
 	idle := make(map[switchPort]struct{})          // this is to deduplicate things
 	for {
+		t.core.log.Debugf("Switch state: idle = %d, buffers = %d", len(idle), len(t.queues.bufs))
 		select {
 		case bytes := <-t.packetIn:
 			// Try to send it somewhere (or drop it if it's corrupt or at a dead end)