From f929df1ea94e53e8983d04350e3a8228e273a215 Mon Sep 17 00:00:00 2001 From: Arceliar Date: Thu, 18 Jan 2018 18:48:34 -0600 Subject: [PATCH] minor performance adjustments --- src/yggdrasil/router.go | 18 ++++++++++++++++-- src/yggdrasil/switch.go | 20 +++++++++++--------- src/yggdrasil/udp.go | 11 +++++++---- 3 files changed, 34 insertions(+), 15 deletions(-) diff --git a/src/yggdrasil/router.go b/src/yggdrasil/router.go index 5d13b8d2..836293ca 100644 --- a/src/yggdrasil/router.go +++ b/src/yggdrasil/router.go @@ -138,7 +138,14 @@ func (r *router) sendPacket(bs []byte) { fallthrough //default: go func() { sinfo.send<-bs }() default: - sinfo.send <- bs + for { + select { + case sinfo.send <- bs: + return + default: + util_putBytes(<-sinfo.send) + } + } } } @@ -189,7 +196,14 @@ func (r *router) handleTraffic(packet []byte) { return } //go func () { sinfo.recv<-&p }() - sinfo.recv <- &p + for { + select { + case sinfo.recv <- &p: + return + default: + util_putBytes((<-sinfo.recv).payload) + } + } } func (r *router) handleProto(packet []byte) { diff --git a/src/yggdrasil/switch.go b/src/yggdrasil/switch.go index 15c54595..72cc96d2 100644 --- a/src/yggdrasil/switch.go +++ b/src/yggdrasil/switch.go @@ -125,13 +125,14 @@ type switchMessage struct { type switchPort uint64 type tableElem struct { - locator switchLocator + port switchPort firstSeen time.Time + locator switchLocator } type lookupTable struct { self switchLocator - elems map[switchPort]tableElem + elems []tableElem } type switchData struct { @@ -163,7 +164,7 @@ func (t *switchTable) init(core *Core, key sigPubKey) { peers := make(map[switchPort]peerInfo) t.data = switchData{locator: locator, peers: peers} t.updater.Store(&sync.Once{}) - t.table.Store(lookupTable{elems: make(map[switchPort]tableElem)}) + t.table.Store(lookupTable{}) t.drop = make(map[sigPubKey]int64) doTicker := func() { ticker := time.NewTicker(time.Second) @@ -380,18 +381,19 @@ func (t *switchTable) updateTable() { defer t.mutex.RUnlock() newTable := lookupTable{ self: t.data.locator.clone(), - elems: make(map[switchPort]tableElem), + elems: make([]tableElem, 0, len(t.data.peers)), } for _, pinfo := range t.data.peers { //if !pinfo.forward { continue } loc := pinfo.locator.clone() loc.coords = loc.coords[:len(loc.coords)-1] // Remove the them->self link - newTable.elems[pinfo.port] = tableElem{ + newTable.elems = append(newTable.elems, tableElem{ locator: loc, //degree: pinfo.degree, firstSeen: pinfo.firstSeen, //forward: pinfo.forward, - } + port: pinfo.port, + }) } t.table.Store(newTable) } @@ -414,7 +416,7 @@ func (t *switchTable) lookup(dest []byte, ttl uint64) (switchPort, uint64) { } // score is in units of bandwidth / distance bestScore := float64(-1) - for port, info := range table.elems { + for _, info := range table.elems { if info.locator.root != table.self.root { continue } @@ -422,10 +424,10 @@ func (t *switchTable) lookup(dest []byte, ttl uint64) (switchPort, uint64) { if !(dist < myDist) { continue } - score := getBandwidth(port) + score := getBandwidth(info.port) score /= float64(1 + dist) if score > bestScore { - best = port + best = info.port bestScore = score } } diff --git a/src/yggdrasil/udp.go b/src/yggdrasil/udp.go index 5a16c7ed..e8258e6d 100644 --- a/src/yggdrasil/udp.go +++ b/src/yggdrasil/udp.go @@ -223,10 +223,13 @@ func (iface *udpInterface) handleKeys(msg []byte, addr connAddr) { } conn.peer.out = func(msg []byte) { defer func() { recover() }() - select { - case conn.out <- msg: - default: - util_putBytes(msg) + for { + select { + case conn.out <- msg: + return + default: + util_putBytes(<-conn.out) + } } } go func() {